Better cleanup of incremental tasks #1189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two bugs:
These are both due to the change introduced in d6ba7e3 which considered deploy failures and cancellations as non-immediate kills for the sake of incremental deploy rollbacks as mentioned in the first point above.
This PR updates the deploy checker and cleaner to be more aware of incremental vs non-incremental deploy failures so that the cleanup can be done appropriately, as well as cleaning up tasks from failed incremental deploys in a more rolling fashion (similar to incremental bounce)
/cc @tpetr