replace instead of ignore so that we can update the offset #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaber
reviewed
Nov 2, 2016
| */ | ||
| @VisibleForTesting | ||
| MesosFileChunkObject parseResponseBody(Response response) throws IOException { | ||
| // not thread-safe, need to make a new one each time; | ||
| CharsetDecoder decoder = StandardCharsets.UTF_8.newDecoder().onMalformedInput(CodingErrorAction.IGNORE); | ||
| CharsetDecoder decoder = StandardCharsets.UTF_8.newDecoder().onMalformedInput(CodingErrorAction.REPLACE); |
There was a problem hiding this comment.
Maybe call replaceWith(REPLACEMENT_CHARACTER) to be more explicit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jhaber what do you think about this tweak? using
REPLACEinstead ofIGNOREallows us to update theoffsetwhen we skip over a bytes in the beginning of a chunk./cc @ssalinas #1334