Transition onLoad to an action dispatcher #1468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the changes that was blocked on the tailer was making `onLoad` behave like an action dispatcher, rather than a function. So each of the components treats it as an object (or, at least, the base case is `null` rather than `_.noop`). This means that it was misbehaving when it wasn't explicitly set because pre-tailer it was expected to be a function.
|
Funny enough I already snuck that into #1466. Looked like it was already that way on some branches and not others. Will roll it out with that one 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the changes that was blocked on the tailer was making
onLoadbehave like an action dispatcher, rather than a function. So each of the
components treats it as an object (or, at least, the base case is
nullrather than
_.noop). This means that it was misbehaving when itwasn't explicitly set because pre-tailer it was expected to be a
function.
More specifically, some pages were permanently stuck with the page loaded, but a visible loading spinner still present