Repository navigation
Reorganize request group view - #1603
Merged
Merged
Conversation
Contributor
|
I definitely like the side menu layout here. Two questions/comments:
|
Contributor
Author
The only caveat is that it won't show up until the user selects it for the first time. Otherwise we'd have to preload all the requests, which slows things down significantly. Not sure if that's a good tradeoff. |
Contributor
|
I think that's an ok tradeoff. Just to clarify, by 'load all the requests', your talking about individual calls for each in the group, not the /requests endpoint right? |
Contributor
Author
|
Correct, I mean the request details for each. |
Contributor
|
👍 |
ssalinas
approved these changes
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Switches to using a side nav instead of tabs for better usability with large request groups. Also makes the feature more noticeable.
Desktop
Mobile
Menu
(Also has
Apply to all requests in grouptooltip)