New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize request group view #1603

Merged
merged 7 commits into from Aug 21, 2017

Conversation

Projects
None yet
3 participants
@kwm4385
Contributor

kwm4385 commented Jul 27, 2017

Switches to using a side nav instead of tabs for better usability with large request groups. Also makes the feature more noticeable.

Desktop

image

Mobile

local hubteamqa com-3334-singularity-ui-group-kafkaopssignals iphone 6 plus

Menu

(Also has Apply to all requests in group tooltip)

image

kwm4385 added some commits Jul 27, 2017

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 28, 2017

Member

I definitely like the side menu layout here. Two questions/comments:

  • Does it collapse? (Not sure if we need it to or not since the width is about the same after taking the margins away)
  • The current UI will show the error banner if one request in the group is not found or is failed on fetch. Would it be possible to maybe display this status in the sidebar as opposed to having the warning banner? Something like a different color/tooltip/etc if we couldn't fetch the data for that request?
Member

ssalinas commented Jul 28, 2017

I definitely like the side menu layout here. Two questions/comments:

  • Does it collapse? (Not sure if we need it to or not since the width is about the same after taking the margins away)
  • The current UI will show the error banner if one request in the group is not found or is failed on fetch. Would it be possible to maybe display this status in the sidebar as opposed to having the warning banner? Something like a different color/tooltip/etc if we couldn't fetch the data for that request?

kwm4385 added some commits Jul 28, 2017

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Jul 28, 2017

Contributor
  • The sidebar doesn't collapse. I don't think it's needed since the request section still has the same available width.

  • I stopped the error banner and added a label to the menu if a request has been deleted:

image

The only caveat is that it won't show up until the user selects it for the first time. Otherwise we'd have to preload all the requests, which slows things down significantly. Not sure if that's a good tradeoff.

Contributor

kwm4385 commented Jul 28, 2017

  • The sidebar doesn't collapse. I don't think it's needed since the request section still has the same available width.

  • I stopped the error banner and added a label to the menu if a request has been deleted:

image

The only caveat is that it won't show up until the user selects it for the first time. Otherwise we'd have to preload all the requests, which slows things down significantly. Not sure if that's a good tradeoff.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 28, 2017

Member

I think that's an ok tradeoff. Just to clarify, by 'load all the requests', your talking about individual calls for each in the group, not the /requests endpoint right?

Member

ssalinas commented Jul 28, 2017

I think that's an ok tradeoff. Just to clarify, by 'load all the requests', your talking about individual calls for each in the group, not the /requests endpoint right?

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Jul 28, 2017

Contributor

Correct, I mean the request details for each.

Contributor

kwm4385 commented Jul 28, 2017

Correct, I mean the request details for each.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 28, 2017

Member

👍

Member

ssalinas commented Jul 28, 2017

👍

@kwm4385 kwm4385 added the hs_stable label Aug 3, 2017

@kwm4385 kwm4385 merged commit ec20e2b into master Aug 21, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@kwm4385 kwm4385 deleted the reorganize-group-page branch Aug 21, 2017

@baconmania baconmania added this to the 0.17.0 milestone Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment