Corrected path for executor download fallback #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetr
reviewed
Nov 27, 2017
| @@ -194,7 +194,7 @@ private void downloadRemoteArtifact(RemoteArtifact remoteArtifact, ArtifactManag | |||
| if (Objects.toString(fetched.getFileName()).endsWith(".tar.gz")) { | |||
| artifactManager.untar(fetched, task.getArtifactPath(remoteArtifact, task.getTaskDefinition().getTaskDirectoryPath())); | |||
| } else { | |||
| artifactManager.copy(fetched, task.getArtifactPath(remoteArtifact, task.getTaskDefinition().getTaskAppDirectoryPath()), remoteArtifact.getFilename()); | |||
| artifactManager.copy(fetched, task.getArtifactPath(remoteArtifact, task.getTaskDefinition().getTaskDirectoryPath()), remoteArtifact.getFilename()); | |||
There was a problem hiding this comment.
is this correct in every circumstance? I think we need to combine getTaskDirectoryPath() and targetFolderRelativeToTask() (if present)
There was a problem hiding this comment.
nevermind, I forgot that's already happening in getArtifactPath()
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was using the task app directory when copying (not unzipping) which does not match what the S3Downloader service does, and does not match what untar does. This updates it to match