New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better catch for statusUpdate exceptions #1708

Merged
merged 2 commits into from Feb 14, 2018

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Feb 13, 2018

When enqueueing a status update to be processed asynchronously, if we hit the maxStatusUpdateQueueSize limit, a RejectedExecutionException is thrown before processStatusUpdateAsync returns. The exception is not in the CompletableFuture.

This adds an additional catch and some better logging for this case.

@ssalinas ssalinas added this to the 0.19.0 milestone Feb 13, 2018

@baconmania

This comment has been minimized.

Contributor

baconmania commented Feb 13, 2018

🚢

@ssalinas ssalinas added the hs_stable label Feb 13, 2018

@ssalinas ssalinas merged commit bd4d2ff into master Feb 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the exit_logging branch Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment