New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better check for finish of a bounce #1732

Merged
merged 4 commits into from Feb 27, 2018

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Feb 22, 2018

Check if a bounce is complete during statusUpdate instead of during cleanup runs. Previously if the cleanup type got overriden or the task exited in an unexpected way, the cleanup could be deleted in such a way that we never check the bounce status again. By checking in the status update, if the request is bouncing we can always determine if the bounce is finished by checking the list of active task ids for any remaining active tasks in cleaning status due to a bounce.

@ssalinas ssalinas added the hs_staging label Feb 22, 2018

@ssalinas ssalinas added this to the 0.20.0 milestone Feb 22, 2018

@ssalinas ssalinas added the hs_qa label Feb 22, 2018

@baconmania

This comment has been minimized.

Show comment
Hide comment
@baconmania

baconmania Feb 26, 2018

Contributor

🚢

Contributor

baconmania commented Feb 26, 2018

🚢

@ssalinas ssalinas added the hs_stable label Feb 27, 2018

@ssalinas ssalinas merged commit 65ebac1 into master Feb 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the bounce_lock_fix branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment