Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor calling of offer evaluation #1932

Merged
merged 9 commits into from
Jun 7, 2019
Merged

Refactor calling of offer evaluation #1932

merged 9 commits into from
Jun 7, 2019

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented May 1, 2019

While looking into some odd offer issues, I noticed that our invocations of checking offers differed slightly between the SchedulerImpl and the SchedulerPoller. This does two things:

  • Consolidates all offer evaluation logic for new and cached offers in the SingularityMesosOfferScheduler class, so the same logic is called in all places
  • Moves the drainPendingQueue operation to only the scheduler poller, since there is no need to call it on every offer run (which can be multiple times a second), making offer evaluation a bit more efficient
  • Add logging on all possible offers that were used to launch a task so we have a better record of all of them

@ssalinas ssalinas added the hs_qa label May 22, 2019
@baconmania
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit f1b2960 into master Jun 7, 2019
@ssalinas ssalinas deleted the revisit_offer_cache branch June 7, 2019 15:51
@ssalinas ssalinas added this to the 0.23.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baconmania baconmania baconmania left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ssalinas @baconmania