-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even number across racks #906
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
32111b1
Doesn't work yet, but a suggestion dialog pops up to confirm how many…
e1c24a0
Radio buttons to choose how many isntances to scale to between the su…
2b67f33
Ignore errors fetching racks and scale anyway
b885f17
Remove junk variable that was being used in testing, and was accident…
e5c21b3
Enable opt out of even number across racks.
b2ebd00
Edit out a debugger call that was accidentally left in
Calvinp 0eea6a9
Added checkbox to even number of tasks hint to disable the hint for e…
c994363
Remove some code that made sense locally but not in production
20a68bf
Merge pull request #949 from HubSpot/opt-out-of-even-number-across-racks
ssalinas b8dba47
Fix change to unrelated file that broke checkbox in bounce dialogue
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
SingularityUI/app/templates/vex/requestScaleConfirmRacks.hbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
<p> | ||
We cannot distribute {{ instances }} | ||
{{#if notOneInstance}} | ||
instances | ||
{{else}} | ||
instance | ||
{{/if}} | ||
evenly across our {{ racks }} | ||
{{#if notOneRack}} | ||
racks. | ||
{{else}} | ||
rack. | ||
{{/if}} | ||
This will result in increased load on {{mod}} | ||
{{#if modNotOne}} | ||
racks. | ||
{{else}} | ||
rack. | ||
{{/if}} | ||
</p> | ||
<p> | ||
We suggest scaling to | ||
{{#if lower}} | ||
either <strong>{{ lower }}</strong> or | ||
{{/if}} | ||
<strong>{{ higher }}</strong> instances. | ||
How many instances would you like to scale to? | ||
</p> | ||
<div id="instances"> | ||
{{#if lower}} | ||
<input type="radio" name="instances" id="lower" value="{{ lower }}"> <label for="lower" id="lower-label">{{ lower }} instances</label><br/> | ||
{{/if}} | ||
<input type="radio" name="instances" id="default" value="{{ instances }}" checked> <label for="default" id="default-label">{{ instances }} | ||
{{#if notOneInstance}} | ||
instances | ||
{{else}} | ||
instance | ||
{{/if}} | ||
</label><br/> | ||
<input type="radio" name="instances" id="higher" value="{{ higher }}"> <label for="higher" id="higher-label">{{ higher }} instances</label><br/> | ||
</div> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be sure to catch errors here. If the call to fetch the number of racks fails for some reason, we should allow the user to continue without the extra prompt