Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneralStore@3.0.0 with hooks #64

Merged
merged 5 commits into from Mar 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 5 additions & 7 deletions .babelrc
@@ -1,10 +1,8 @@
{
"plugins": [
"transform-class-properties"
],
presets: [
"es2015",
"react",
"stage-2"
"plugins": ["@babel/plugin-proposal-class-properties"],
"presets": [
"@babel/preset-env",
"@babel/preset-react",
"@babel/preset-typescript"
]
}
23 changes: 17 additions & 6 deletions .eslintrc
@@ -1,11 +1,22 @@
{
"extends": [
"plugin:react/recommended",
"prettier",
"prettier/react",
],
"parser": "babel-eslint",
"extends": ["prettier", "plugin:react-app/recommended"],
"plugins": ["@typescript-eslint", "react-app", "jest", "react-hooks"],
"parser": "@typescript-eslint/parser",
"env": {
"jest": true
},
"parserOptions": {
"ecmaVersion": 2018,
"sourceType": "module",
"ecmaFeatures": {
"jsx": true
}
},
"rules": {
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "warn",
"react-app/import/first": 0,
"no-unused-vars": 0,
"@typescript-eslint/no-unused-vars": "error"
}
}
8 changes: 0 additions & 8 deletions .flowconfig

This file was deleted.

5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
@@ -1,7 +1,6 @@


**TODOs**

- [ ] linter, checker, and test are passing
- [ ] any new public modules are exported from `src/GeneralStore.js`
- [ ] version numbers are up to date in `package.json` and `bower.json`
- [ ] version numbers are up to date in `package.json`
- [ ] `CHANGELOG.md` is up to date
4 changes: 0 additions & 4 deletions .gitignore
Expand Up @@ -27,10 +27,6 @@ node_modules
# Users Environment Variables
.lock-wscript

# bower
bower_components
src/bower_components

# build stuff
dist
lib
2 changes: 1 addition & 1 deletion .travis.yml
@@ -1,4 +1,4 @@
language: node_js
node_js:
- "6.0"
- "8"
script: npm run build-and-test
8 changes: 8 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,11 @@
## 3.0.0
* Removes the following APIs
* `StoreDependencyMixin`
* `connectWithState`
* Adds a `useStoreDependency` [hook](https://reactjs.org/docs/hooks-intro.html) for use with `react@^16.8.0`.
* `prop-types` added as a peer dependency as it has been removed from the main React package
* Migrated from Flow to TypeScript

## 2.5.1
* Support React 16.x by using [hoist-non-react-statics@2.5.0](https://github.com/mridgway/hoist-non-react-statics) (without `ForwardRef` support)

Expand Down