Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit supporting namespaces #649

Merged
merged 9 commits into from
Apr 30, 2021
Merged

Revisit supporting namespaces #649

merged 9 commits into from
Apr 30, 2021

Conversation

jasmith-hs
Copy link
Contributor

This PR builds off of @pastorcmentarny's PR #306 with a few modifications:

  • Allows multiple namespaces in any context
  • Allows namespaces to be constructed like in Jinja with an optional dictionary to initialize with and optional keyword arguments
  • Makes Namespace an extension of HashMap<String, Object>
  • Also adds necessary logic for namespaces to work with eager execution.

This PR will close out #274

@jasmith-hs jasmith-hs requested a review from boulter April 30, 2021 17:09
@jasmith-hs jasmith-hs merged commit 2197bb7 into master Apr 30, 2021
@jasmith-hs jasmith-hs deleted the namespaces branch April 30, 2021 18:37
@ssalonen ssalonen mentioned this pull request Aug 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulter boulter boulter approved these changes

@mattcoley mattcoley Awaiting requested review from mattcoley

Assignees
No one assigned
Labels
Eager Execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasmith-hs @boulter