Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up camera-tool #5607

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Clean up camera-tool #5607

merged 1 commit into from
Aug 17, 2022

Conversation

takahirox
Copy link
Contributor

From: #5604

Use material.onBeforeRender instead of object.onBeforeRender.

@takahirox
Clean up camera-tool
d21891a 
Use material.onBeforeRender instead of object.onBeforeRender
@takahirox takahirox mentioned this pull request Jul 22, 2022
Merged
brianpeiris
brianpeiris approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@brianpeiris brianpeiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takahirox takahirox merged commit fd07724 into master Aug 17, 2022
@takahirox takahirox deleted the CleanUpCameraTool branch August 17, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpeiris brianpeiris brianpeiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takahirox @brianpeiris