Fix darkened video-texture-target #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes darkened video-texture-target problem caused when upgrading our Three.js to r141. Refer to "Fix darkened camera view" commit for the details because the root issue is same.
takahirox
commented
Jul 21, 2022
| material.map.isVideoTexture = true; | ||
| material.map.update = () => { | ||
| // Only update the renderTarget when the screens are in view | ||
| material.onBeforeRender = () => { |
There was a problem hiding this comment.
Note to reviews: I assume material.onBeforeRender isn't set anywhere else.
There was a problem hiding this comment.
Oh wow I didn't realize this existed for materials. Well that makes things simple. We should probably use that for camera tool too then.
There was a problem hiding this comment.
Sounds good to me. Opened #5607
netpro2k
approved these changes
Jul 22, 2022
Merged
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5599
This PR fixes darkened video-texture-target problem caused when upgrading our Three.js to r141.
Refer to "Fix darkened camera view" PR #5577 for the details because the root issue is same.