Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config properties to readme #36

Merged
merged 4 commits into from
Jan 4, 2017
Merged

Add config properties to readme #36

merged 4 commits into from
Jan 4, 2017

Conversation

ndelvalle
Copy link
Member

This PR adds the configuration object to the readme

Copy link
Member

@gillchristian gillchristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🕶️

Maybe add which are the default values for each param.

cache: 'default'
}
```
More information about Request properties can be found at developer mozilla [website](https://developer.mozilla.org/en-US/docs/Web/API/Request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelvalle
Copy link
Member Author

LGTM

@gillchristian gillchristian merged commit 0d7fd1e into master Jan 4, 2017
@gillchristian gillchristian deleted the config branch January 4, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants