Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cms branch param from master #2705

Merged
merged 1 commit into from
May 8, 2022
Merged

Rename cms branch param from master #2705

merged 1 commit into from
May 8, 2022

Conversation

nathansrf
Copy link
Contributor

Github has changed from using master -> main as the default branch name for new repos. So when netlify creates a new repo based on this template, the default branch is named 'main' instead of 'master'.

Leaving this config param as 'master' will result in a credentials error whenever a user tries to login using the /admin page. Renaming this to 'main' fixes the error.

Purpose

Describe the purpose of this change. If there is an existing issue that is resolved by this pull request, please reference it in the form Fixes #1234 where 1234 is the relevant issue number.

Screenshots

If this is a GUI change, try to include screenshots of the change. If not, please delete this section.

Documentation

If this is an enhancement, add a link here to the corresponding pull request on https://github.com/sourcethemes/academic-www or describe the documentation changes necessary.

Github has changed from using master -> main as the default branch name for new repos. So when netlify creates a new repo based on this template, the default branch is named 'main' instead of 'master'.

Leaving this config param as 'master' will result in a credentials error whenever a user tries to login using the /admin page. Renaming this to 'main' fixes the error.
@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for hugo-portfolio-theme canceled.

Name Link
🔨 Latest commit a14e86c
🔍 Latest deploy log https://app.netlify.com/sites/hugo-portfolio-theme/deploys/6277ac03a4d7b70008804622

@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for markdown-slides canceled.

Name Link
🔨 Latest commit a14e86c
🔍 Latest deploy log https://app.netlify.com/sites/markdown-slides/deploys/6277ac03c7c5b30008a2f765

@gcushen gcushen merged commit 6b1f2f3 into HugoBlox:main May 8, 2022
ramet pushed a commit to ramet/hugo-academic that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants