Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count quantities with mecab japanese #149

Merged
merged 3 commits into from Dec 26, 2023
Merged

Conversation

ProgramComputer
Copy link

@ProgramComputer ProgramComputer commented Oct 3, 2023

Recognize quantities as words such as 二十五 or 十五 using mecab.

@ProgramComputer ProgramComputer changed the base branch from master to dev October 3, 2023 05:52
@HugoFara HugoFara added bug Something isn't working enhancement Develop an existing feature ui Any problem related to the User Interface labels Dec 25, 2023
@HugoFara HugoFara merged commit 3f0f204 into HugoFara:dev Dec 26, 2023
4 checks passed
@HugoFara
Copy link
Owner

Hi @ProgramComputer ! I have reviewed and merge your commit, thanks for the PR!
Just for the record, here is how LWT used to parse:

no number parsing

Here is the new result:

japanese number parsing

To be honest I was aware of the issue, but did not find it concerning as numbers are roughly fifteen characters. But I was already told it existed, LUTE published the feature and now you come with a PR request so I changed my mind and I'm glad it is implemented!

HugoFara added a commit that referenced this pull request Dec 26, 2023
HugoFara added a commit that referenced this pull request Dec 27, 2023
Fixes/Implements #149: adds counting in japanese.
Fixes #155: MeCab was always set for japanese.
Fixes romanization with MeCab not displayed.
Typo and link fixing in documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Develop an existing feature ui Any problem related to the User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants