-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Mecab required when not set #155
Conversation
Hi @ProgramComputer, thank you for the pull request! I implemented the manually changes, here are the details:
Have a great day! |
887ac35 is a UI fix. The cause of MeCab bug is on Line 4810 in b64cd6a
|
That makes sense, actually I may create a new function |
Lg_ID can work after seeing #103 (comment) for Mecab to be enabled independent of language. |
652e00d
to
cf3f99b
Compare
I added a new parameter |
New databse migration strategy. Fixes feeds (#168). Adds missing documentation to Docker (#146, #160). Changes in PHP and JS globals. Fixes reading position was not set. Read text through API (#153, #155). Fixes word was not saved/deleted. Fixes #170 and #69. Updates API (#175). Adds dependency to php-xml (#178, #181). Updates makefile (#179). Adds MeCab support on Mac (#135). Adds the option to hide/show word romanization (#119). Raises URL size limit to 2048 (#144).
Bug not fixed yet, opened #182. |
Even when mecab was not set for Japanese; it would require it installed. Also changed phonetic reading to take LanguageName as that is the key used in the language table and not the language code.