Fix opening files with Open With... #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way the
open
signal works, files can also be opened with the CLI now.I added a default height to the window because it would load the window at a really small height when opening files this way. If my calculations are correct, the
default-height
it's 8 pixels bigger than the window usually opens. I did that because 500 is a nicer number than 492, and I don't think anyone will care or even notice. I also found that the method theopen
signal is connected to automatically runs if it's calleddo_open()
, so I went ahead and edited that. If you want that change reverted, I can do that.I'm also not sure where else to say this, but in the release for 1.9.0, you mentioned my old GitHub account instead of this one on accident. I got locked out of it a while ago and kind of forgot that it existed. My current username has a 1 instead of an I, which is admittedly a small change, but I just thought it'd be good for you to know. Sorry if this wasn't the right place to do it, I'm not sure where else to.
Closes #173.