Simplify UI code #221
Merged
Simplify UI code #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code cleaner by removing and replacing redundant code.
This was done because it's easier to see "true" or "false" to know what a bool property is set to compared to a number, and the goal of this PR was to clean and improve readability.
|
That's perfect thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
gtk4-builder-tool, the UI files were simplified, with lines that set properties to their defaults removed along with whitespace, etc. It also switched bools to0and1s, but I reverted that since I felt that it was easier to read and understand a bool at a glance, and the point of this was to improve readability and cleanliness. You can close this if you feel it's not important or useful.