Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1993 #2043

Merged
merged 1 commit into from Oct 27, 2019
Merged

fix #1993 #2043

merged 1 commit into from Oct 27, 2019

Conversation

Mogge
Copy link
Member

@Mogge Mogge commented Oct 25, 2019

馃嵃 Pullrequest

fix #1993 by adding option autoCropArea: 1.0 to Cropper

Issues

  • None

Todo

  • None

Copy link
Member

@mattwr18 mattwr18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Mogge, I wonder if it's obvious that you can crop the image now... it was a bit difficult to see the blue crop overlay lines, but you met the conditions of the issue, and we can see how the users like it.

Great job!!

@mattwr18 mattwr18 merged commit ca63a3b into master Oct 27, 2019
@mattwr18 mattwr18 deleted the fix-1993 branch October 27, 2019 11:23
@erhardtstiefel erhardtstiefel mentioned this pull request Dec 11, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃殌 [Feature] Set default image cropping size to 100%
2 participants