Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍰 2119-Fix Contribution consistent form input validation #2160

Merged
merged 21 commits into from Nov 18, 2019
Merged

🍰 2119-Fix Contribution consistent form input validation #2160

merged 21 commits into from Nov 18, 2019

Conversation

ogerly
Copy link
Contributor

@ogerly ogerly commented Nov 7, 2019 •
edited

🍰 Pullrequest

Fix consistent form input validation

ezgif com-video-to-gif (2)

Behaviour 1

FireShot Capture 188 - Human Connection - Human Connection - localhost

Behaviour 2

FireShot Capture 187 - Human Connection - Human Connection - localhost

Behaviour 3

FireShot Capture 186 - Human Connection - Human Connection - localhost

Issues

@ogerly ogerly added the feature label Nov 7, 2019
@ogerly ogerly self-assigned this Nov 7, 2019
@ogerly ogerly added this to To Do in Human-Connection via automation Nov 7, 2019
@ogerly ogerly requested a review from a team November 7, 2019 08:25
@ogerly ogerly changed the title 2119-Fix consistent form input validation 2119-Fix Controbition consistent form input validation Nov 7, 2019
@ogerly ogerly changed the title 2119-Fix Controbition consistent form input validation 🍰 2119-Fix Contribution consistent form input validation Nov 7, 2019
@Tirokk
Copy link
Member

Tirokk commented Nov 7, 2019 •
edited

Hey, chick @ogerly ,
I will make a review tomorrow morning.

Cool with the red triangles !!! 😎

The only thing I say right away to the design is:
I would only make left align of the language menu and not a right align.
This is much to wide.
What you say?

@ogerly
Copy link
Contributor Author

ogerly commented Nov 7, 2019

@Tirokk I pulled the select bar over the whole box so it comes across better.
on mobile largest it also runs over the whole box. and the importance is even more clear.
i can do it left justified and 50% flex
i needed it a bit bigger because of the german text that was broken in the beginning and stood over

@ogerly ogerly changed the title 🍰 2119-Fix Contribution consistent form input validation 🍰 [WIP] 2119-Fix Contribution consistent form input validation Nov 8, 2019
@roschaefer
Merge remote-tracking branch 'origin/2119_Create_Post_consistent_form…
4108bb7 
…_input_validation' into 2119_Create_Post_consistent_form_input_validation-improvements
@roschaefer
Fix CSS classes
6c947f7
@roschaefer
fix: send 403 if you try to edit another's post
7c278d7 
This also fixes the glitch that you click on "Edit post" and the
contribution form is empty.
@ogerly ogerly mentioned this pull request Nov 11, 2019
Closed
@ogerly
Copy link
Contributor Author

ogerly commented Nov 11, 2019

this PR is closed and here it goes on #2189

@ogerly ogerly closed this Nov 11, 2019
Human-Connection automation moved this from To Do to Done Nov 11, 2019
@alina-beck alina-beck mentioned this pull request Nov 11, 2019
Merged
1 task
@roschaefer roschaefer reopened this Nov 12, 2019
Human-Connection automation moved this from Done to In progress Nov 12, 2019
roschaefer and others added 9 commits November 15, 2019 11:55
@roschaefer
Fix cypress tests
edbb0c3
@roschaefer
Follow @mattwr18 suggestions
c20a656
@mattwr18
Merge pull request #2163 from Human-Connection/2119_Create_Post_consi…
0ca2018 
…stent_form_input_validation-improvements

2119 create post consistent form input validation improvements
@mattwr18
Merge branch 'master' of github.com:Human-Connection/Human-Connection…
6685ff3 
… into 2119_Create_Post_consistent_form_input_validation
@mattwr18
Fix lint
04f07b9
@mattwr18
Decrease width of language select, pull right
0815a12 
- @ogerly hope you are cool with this, I pulled it right so that the
validations you added still all line up on the right side

- @alina-beck I think you know a more sophisticated way to do this, it
was just easy for me to add an empty <ds-flex-item> with a 50% width on
medium and larger devices. This can also be populated with country of
contribution or visibility, when one of those is implemented.. what do
you think?
@mattwr18
Update validations for a Post's content
5450eba 
- we were asked to remove a minimum of three characters since it's not
more substantive than a link.
@mattwr18
Update tests to test new validations
399e133
@mattwr18
Fix lint with updated linter
123fc2f
roschaefer
roschaefer approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Great teamwork!

great teamwork

@mattwr18 mattwr18 changed the title 🍰 [WIP] 2119-Fix Contribution consistent form input validation 🍰 2119-Fix Contribution consistent form input validation Nov 18, 2019
@cypress
Copy link

cypress bot commented Nov 18, 2019


Test summary

48 • 0 • 0 • 0

Run details
Project Human-Connection
Status Passed
Commit 9864532
Started Nov 18, 2019 11:13 PM
Ended Nov 18, 2019 11:26 PM
Duration 13:01 💡
OS Linux Ubuntu Linux - 16.04
Browser Chromium 78

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mattwr18 mattwr18 merged commit c775884 into master Nov 18, 2019
Human-Connection automation moved this from In progress to Done Nov 18, 2019
@mattwr18 mattwr18 deleted the 2119_Create_Post_consistent_form_input_validation branch November 18, 2019 23:27
This was referenced Oct 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roschaefer roschaefer roschaefer approved these changes

@Tirokk Tirokk Awaiting requested review from Tirokk

@mattwr18 mattwr18 Awaiting requested review from mattwr18

@alina-beck alina-beck Awaiting requested review from alina-beck

Assignees

@ogerly ogerly

Labels
feature
Projects
Human-Connection
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [Feature] Create Post – consistent form input validation
4 participants
@ogerly @Tirokk @roschaefer @mattwr18