Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge contribution consistent form input validation #2160 in create post consistent form input validation improvements #2164 #2189

Closed
wants to merge 3 commits into from

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Oct 5, 2020

ogerly Authored by ogerly
Nov 11, 2019
Closed Nov 11, 2019


🍰 Pullrequest

Merge contribution consistent form input validation #2160 in create post consistent form input validation improvements #2164

Human-Connection/Human-Connection#2163

IN

Human-Connection/Human-Connection#2160

ezgif com-video-to-gif (2)

Behaviour 1

FireShot Capture 188 - Human Connection - Human Connection - localhost

Behaviour 2

FireShot Capture 187 - Human Connection - Human Connection - localhost

Behaviour 3

FireShot Capture 186 - Human Connection - Human Connection - localhost

Issues

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

ogerly Authored by ogerly
Nov 11, 2019


Robert's work is better. Human-Connection/Human-Connection#2163

@Tirokk
Copy link
Member Author

Tirokk commented Oct 7, 2020

datenbrei Authored by datenbrei
Nov 12, 2019


I'd prefer the first behaviour of these above. Very good comparision, @ogerly !

@Mogge Mogge closed this Oct 8, 2020
@ulfgebhardt ulfgebhardt deleted the pr2189head branch August 2, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants