feat: 🍰 Admin - Remove User Profile #3140

ogerly · 2020-02-23T05:48:30Z

🍰 Pullrequest

Delete a user as Admin.
A new modal is added.

The admin has the possibility to permanently delete a user account from the network.

At present, all contributions and comments of a user account are automatically and irrevocably deleted / overwritten.

There is a second security question where you have to confirm the deletion a second time.

Issues

fixes 🚀 [Feature] Admin - Remove user profile #17

cypress · 2020-02-23T06:19:50Z

Test summary

66 • 0 • 0 • 0

Run details


Project	Human-Connection
Status	Passed
Commit	`fde69a3`
Started	Aug 27, 2020 8:10 AM
Ended	Aug 27, 2020 8:33 AM
Duration	22:30 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Firefox 68

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress · 2020-02-23T06:30:07Z

Test summary

66 • 0 • 0 • 0

Run details


Project	Human-Connection
Status	Passed
Commit	`c0698ea` ℹ️
Started	Aug 27, 2020 8:10 AM
Ended	Aug 27, 2020 8:34 AM
Duration	23:21 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Firefox 68

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

…d from the Admin user overview

ogerly · 2020-03-04T15:31:06Z

DeleteUser for Admin added in the profile dropdown menu, deleted from the Admin user overview

ogerly · 2020-03-05T07:19:10Z

i have changed the style, and do not bind the deleteData.vue from the user settings to the modal anymore.
i display the data of the user to be deleted.

Tirokk

I have done a "quick“ review.

I would like to have an additional Modal question, so that an admin can not delete a users account by accidentally clicking the button.
Graphically the modals information looks a bit big to me.
Should there a possibility do decide if all the posts and comments should be deleted or not?

Please let me know if I can help you.

backend/src/middleware/permissionsMiddleware.js

backend/src/schema/resolvers/users.js

webapp/components/DeleteUserModal/DeleteUserModal.vue

webapp/components/Modal.vue

webapp/locales/de.json

Tirokk · 2020-03-05T09:54:09Z

webapp/locales/en.json

      "commentedCount": "Delete my {count} comments",
      "contributionsCount": "Delete my {count} posts",
+      "infoAdmin": "All contributions and comments of the user are additionally deleted!",


… are deleted as well! ?

This is not done yet!

Still not done! 🤔

ogerly · 2020-03-06T07:19:45Z

@Tirokk thx!!, I have made some changes. and an additional confirmModal where you have to confirm the deletion again.

ogerly · 2020-03-06T08:04:58Z

…r-profile

Tirokk · 2020-05-29T09:55:23Z

That being said, I don't think we should completely change it. If other people are happy with this solution, who am I to say change it. Just not how I imagined it.

I understand that you @mattwr18 and @roschaefer have imagined it more like on the delete own account on the settings page.

As I gave my first review I was more in the thinking frame like @ogerly has started this issue. I had not even thought about an admin can or should type the name of the user to delete.
One of the reasons of my thinking frame was probably that the way to trigger the delete goes over the content menu of the users profile page in this case.
But the place to trigger the delete like here I do prefer against the users list of an admin, because the admin has to look the user they delete right into the face, kind of. It’s not as anonym as deleting the user from a list I like to say …

To have an additional page sounds like an overkill to me. Just in case the typing of the users name should really replace the second modal I would go for having the typing of the user name in the first modal then.

What is @ogerly saying and what do other people say? @HC-Team

…an-Connection/Human-Connection into 17-Admin-Remove-user-profile

ogerly · 2020-08-04T14:16:44Z

I have adapted the style a little bit ... see last PR

United States of America TO United States

ogerly

United States of America to United States

Tirokk

Hey @ogerly ,

I have still found some little things, but that should be the last and we can do it together, if you like.

In the following modal I more would like to have the created, Posts, and Comments over the data.
And created should then with a capital Created. And then all three in bold and the data in normal types.

webapp/locales/en.json

webapp/components/ContentMenu/ContentMenu.vue

webapp/components/DeleteData/DeleteData.vue

Tirokk · 2020-08-26T15:07:31Z

webapp/components/Modal/DeleteUserModal.vue

+          `,
+          variables: { id: this.userdata.id, resource: ['Post', 'Comment'] },
+        })
+        .then(({ _data }) => {


Is not fixed yet.
Is this intensionally?

You like it this way better?

webapp/locales/de.json

Tirokk · 2020-08-26T15:09:39Z

webapp/locales/en.json

      "commentedCount": "Delete my {count} comments",
      "contributionsCount": "Delete my {count} posts",
+      "infoAdmin": "All contributions and comments of the user are additionally deleted!",


Still not done! 🤔

Is outdated …

ok Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>

Tirokk

Hey @ogerly ,
great contribution! 🚀🚀💫💫
Well done 🤗

It is so important that an admin can delete a users account.
Therefore I’m really happy that we can merge it. 😍

feature: add New Moadal - deleteUserModal

25b7f16

ogerly requested review from roschaefer, alina-beck, Tirokk and mattwr18 February 23, 2020 05:48

ogerly self-assigned this Feb 23, 2020

ogerly added 2 commits February 23, 2020 17:36

stepstep

fdc0f49

feat: DeleteUser for Admin added in the profile dropdown menu, delete…

9ab2d83

…d from the Admin user overview

ogerly added 3 commits March 5, 2020 08:20

deleteUserModal style changed, deleteData is no longer included

127ddcc

test: Added Spec for DeleteUserModal

ee06039

test: add propsData

26a547c

Tirokk requested changes Mar 5, 2020

View reviewed changes

feat: additional confirm inserted before really deleting

a1114a8

ogerly requested a review from Tirokk March 6, 2020 07:13

ogerly added backend feature labels Mar 6, 2020

feat: Style change DeleteUserModal.vue display userdata overview

7700865

ogerly and others added 5 commits March 6, 2020 10:24

delete DeleteUserModal.specs.js

2843635

sorting locations files yarn run locales --fix

3343e14

Merge branch 'master' into 17-Admin-Remove-user-profile

404713a

sorting locations fix yarn run locales --fix II

42e3b27

change location

b87074b

ogerly changed the title ~~[WIP] feature: add New Moadal - deleteUserModal~~ feature: add New Moadal - deleteUserModal Mar 10, 2020

Merge remote-tracking branch 'origin/master' into 17-Admin-Remove-use…

6a0b5a2

…r-profile

Tirokk changed the title ~~feature: add New Modal - deleteUserModal~~ feature: 🍰 Add New Modal - deleteUserModal Jun 11, 2020

ogerly added 3 commits July 31, 2020 07:36

Merge branch '17-Admin-Remove-user-profile' of https://github.com/Hum…

d2e6280

…an-Connection/Human-Connection into 17-Admin-Remove-user-profile

test check test WIP

a4be3f7

fix: style change in modal deleteUserModal

8b7b105

ogerly and others added 5 commits August 5, 2020 13:45

fix: prework for tests

0b62d76

fix: tests ok, lint ok

3d69ebb

fix: translate delete from single to multiple entries

0455001

Merge branch 'master' into 17-Admin-Remove-user-profile

6d856a3

fix: lint

1b268b4

ogerly requested review from roschaefer and Tirokk August 14, 2020 15:52

ogerly added 3 commits August 18, 2020 11:50

fix: location map box USA

6a68bb8

fix: location nameEN to United States

bbf578f

fix: DeleteDate vue and specs

b2f3b02

ogerly requested review from Mogge and removed request for alina-beck and mattwr18 August 19, 2020 09:53

cange country

abdce9a

United States of America TO United States

ogerly commented Aug 19, 2020

View reviewed changes

Tirokk changed the title ~~feature: 🍰 Add New Modal - deleteUserModal~~ feat: 🍰 Admin - Remove User Profile Aug 26, 2020

Tirokk requested changes Aug 26, 2020

View reviewed changes

ogerly and others added 2 commits August 27, 2020 09:14

Update webapp/locales/en.json

635b7e0

ok Co-authored-by: Wolfgang Huß <wolle.huss@pjannto.com>

fix: review from wolle, fix lint

fde69a3

ogerly requested a review from Tirokk August 27, 2020 07:53

Tirokk approved these changes Aug 27, 2020

View reviewed changes

Tirokk merged commit 47e43f2 into master Aug 27, 2020

Tirokk deleted the 17-Admin-Remove-user-profile branch August 27, 2020 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 🍰 Admin - Remove User Profile #3140

feat: 🍰 Admin - Remove User Profile #3140

ogerly commented Feb 23, 2020 •

edited

Loading

cypress bot commented Feb 23, 2020 •

edited

Loading

cypress bot commented Feb 23, 2020 •

edited

Loading

ogerly commented Mar 4, 2020

ogerly commented Mar 5, 2020

Tirokk left a comment •

edited

Loading

Tirokk Mar 5, 2020

Tirokk May 28, 2020

Tirokk Aug 26, 2020

ogerly commented Mar 6, 2020

ogerly commented Mar 6, 2020 •

edited

Loading

Tirokk commented May 29, 2020 •

edited

Loading

ogerly commented Aug 4, 2020

ogerly left a comment

Tirokk left a comment

Tirokk Aug 26, 2020

Tirokk Aug 26, 2020

Tirokk left a comment

feat: 🍰 Admin - Remove User Profile #3140

feat: 🍰 Admin - Remove User Profile #3140

Conversation

ogerly commented Feb 23, 2020 • edited Loading

🍰 Pullrequest

Issues

cypress bot commented Feb 23, 2020 • edited Loading

Test summary

Run details

cypress bot commented Feb 23, 2020 • edited Loading

Test summary

Run details

ogerly commented Mar 4, 2020

ogerly commented Mar 5, 2020

Tirokk left a comment • edited Loading

Choose a reason for hiding this comment

Tirokk Mar 5, 2020

Choose a reason for hiding this comment

Tirokk May 28, 2020

Choose a reason for hiding this comment

Tirokk Aug 26, 2020

Choose a reason for hiding this comment

ogerly commented Mar 6, 2020

ogerly commented Mar 6, 2020 • edited Loading

Tirokk commented May 29, 2020 • edited Loading

ogerly commented Aug 4, 2020

ogerly left a comment

Choose a reason for hiding this comment

Tirokk left a comment

Choose a reason for hiding this comment

Tirokk Aug 26, 2020

Choose a reason for hiding this comment

Tirokk Aug 26, 2020

Choose a reason for hiding this comment

Tirokk left a comment

Choose a reason for hiding this comment

ogerly commented Feb 23, 2020 •

edited

Loading

cypress bot commented Feb 23, 2020 •

edited

Loading

cypress bot commented Feb 23, 2020 •

edited

Loading

Tirokk left a comment •

edited

Loading

ogerly commented Mar 6, 2020 •

edited

Loading

Tirokk commented May 29, 2020 •

edited

Loading