Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: favor CSS over syleguide components SearchPost.vue #3377

Merged
merged 4 commits into from Apr 7, 2020
Merged

refactor: favor CSS over syleguide components SearchPost.vue #3377

merged 4 commits into from Apr 7, 2020

Commits on Apr 7, 2020

  1. refactor: favor CSS over syleguide components

    @mattwr18
    mattwr18 committed Apr 7, 2020
    Copy the full SHA
    ff44fdb View commit details
    Browse the repository at this point in the history

  2. fix(frontend): update tests with new CSS selectors

    @mattwr18
    mattwr18 committed Apr 7, 2020
    Copy the full SHA
    668159f View commit details
    Browse the repository at this point in the history

  3. use CounterIcon component to show counts 

    - also adds a 'soft' variant to CounterIcon to make it more adaptable
    @alina-beck @mattwr18
    alina-beck authored and mattwr18 committed Apr 7, 2020
    Copy the full SHA
    797efe0 View commit details
    Browse the repository at this point in the history

  4. chore: update variable to avoid validation error 

    - test was throwing a validation error for count as searchResults was
  setting commentCount instead of commentsCount
    @mattwr18
    mattwr18 committed Apr 7, 2020
    Copy the full SHA
    ca5c1a5 View commit details
    Browse the repository at this point in the history