Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-878: Fix shrinking textarea on edit #5665

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Apr 3, 2024

We have TextArea's HtxTextBox (input when you edit text block) updating its height on edit. That was to auto-increase height of multiline blocks. But we stopped taking borders into account some time ago (HumanSignal/label-studio-frontend@c8417d5). Returning it back and fixing condition for empty scrollHeight fixes shrinking input.

  • fix position for "Delete Region" icon — it's in the middle now
Screenshot 2024-04-03 at 16 02 11

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

Describe the reason for change

Inputs and textareas used to edit TextArea tag text blocks were shrinking every time you type something into them.

This change affects (describe how if yes)

  • Performance
  • Security
  • UX

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

We have TextArea's HtxTextBox (input when you edit text block) updating its height on edit.
That was to auto-increase height of multiline blocks. But we stopped taking borders into account
some time ago (HumanSignal/label-studio-frontend@c8417d5).
Returning it back and fixing condition for empty scrollHeight fixes shrinking input.
@github-actions github-actions bot added the fix label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit fe2724d
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/661594baf30f9b0008b8068e

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit fe2724d
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/661594ba749edf000896afde

@hlomzik
Copy link
Collaborator Author

hlomzik commented Apr 5, 2024

/git merge

Workflow run
Successfully merged: 76 files changed, 772 insertions(+), 1183 deletions(-)

@hlomzik
Copy link
Collaborator Author

hlomzik commented Apr 9, 2024

/git merge

Workflow run
Successfully merged: 14 files changed, 152 insertions(+), 51 deletions(-)

@hlomzik hlomzik enabled auto-merge (squash) April 9, 2024 19:09
@hlomzik hlomzik merged commit 6b28a6d into develop Apr 10, 2024
29 checks passed
@hlomzik hlomzik deleted the fb-leap-878/textarea-height branch April 10, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants