Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-872, LEAP-935, LEAP-942, including moving the #5707

Closed
wants to merge 2 commits into from

Conversation

deppp
Copy link
Collaborator

@deppp deppp commented Apr 10, 2024

auto-accept checkbox to the bottom bar, fixing reject all button not working, and removing the regions used for interactivity

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

auto-accept checkbox to the bottom bar, fixing reject all button not
working, and removing the regions use for interactivity
@deppp deppp changed the title bug: fixes for LEAP-872, LEAP-935, LEAP-942, including moving the fix: fixes for LEAP-872, LEAP-935, LEAP-942, including moving the Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 0ce65be
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/661611fdef776100083fa9a8

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 0ce65be
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/661611fd4543a800084f8581

@deppp deppp changed the title fix: fixes for LEAP-872, LEAP-935, LEAP-942, including moving the fix: LEAP-872, LEAP-935, LEAP-942, including moving the Apr 10, 2024
onClick={() => {
const ann = item.annotation;
ann.rejectSuggestion(item.id);
ann.deleteAllDynamicregions(true);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for LEAP-942

onClick={() => {
const ann = item.annotation;
ann.acceptSuggestion(item.id);
ann.deleteAllDynamicregions(true);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for LEAP-942

},

rejectAllSuggestions() {
Array.from(self.suggestions.keys).forEach((id) => {
Array.from(self.suggestions.keys()).forEach((id) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for LEAP-935

@hlomzik
Copy link
Collaborator

hlomzik commented Apr 11, 2024

Closed in favor of #5714

@hlomzik hlomzik closed this Apr 11, 2024
@hlomzik hlomzik deleted the dev/move-auto-accept branch April 11, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants