fix: LEAP-872: LEAP-935: Auto-Annotation fixes #5714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-accept checkbox to the bottom bar, fixing reject all button not working, and removing the regions use for interactivity
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
hlomzik
changed the title
This was referenced Apr 11, 2024
Gondragos
reviewed
Apr 11, 2024
Gondragos
reviewed
Apr 11, 2024
|
/git merge develop
|
hlomzik
added a commit
that referenced
this pull request
Apr 16, 2024
LEAP-872: Move the Auto-Accept checkbox to the bottom bar LEAP-935: Fix Reject All button not working Mirroring #5714 --------- Co-authored-by: Michael Malyuk <michael.malyuk@icloud.com> Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: hlomzik <hlomzik@gmail.com>
Keep original dynamic regions for 1-by-1 accept and reject. This is helpful for Segment Anything keypoints case. https://labelstud.io/blog/get-started-using-segment-anything/#label-with-keypoints
They don't have much sense to be displayed simultaneously. Plus this reduces the space occupied and allows to add more info.
- don't display Auto-Accept panel for not supported tags - display spinner while request is in progress - also dim the toggle if it's there, but don't disable it
hlomzik
changed the title
Gondragos
approved these changes
Apr 17, 2024
hlomzik
approved these changes
Apr 17, 2024
yyassi-heartex
approved these changes
Apr 17, 2024
juliosgarbi
approved these changes
Apr 17, 2024
MihajloHoma
approved these changes
Apr 17, 2024
to conform recent effort for correct extensions
|
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject All fix
Fix of small mistake in order to unblock Reject All button (
keysis a function)Auto-Accept Suggestions toggle
It's moved to Bottom Bar, not blocking the view of annotation anymore. Style is uniform with Auto-Annotation toggle. When there are suggestions on a screen this toggle is replaced with Accept All/Reject All buttons, because it looks confusing to have both at the same time.
Loading suggestions...
Spinner is moved from Auto-Accept panel to Bottom Bar. While it's loading the toggle is dimmed for better visibility. But toggle is active because its value will be used only after request is finished, so it can still be useful.
Now spinner is displayed for any kind of interactive annotations, not only Image ones:
PR fulfills these requirements
Describe the reason for change
LEAP-872: Auto-Accept panel is blocking images
LEAP-935: Reject All button not working
Release PR: #5715
Change has impacts in these area(s)
Does this PR introduce a breaking change?