Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LEAP-1060: Add event to allow control annotations submitting #5891

Merged
merged 9 commits into from
May 23, 2024
Merged

feat: LEAP-1060: Add event to allow control annotations submitting #5891

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1624fda
feat: LEAP-1060: Add event to allow control annotations submitting
Gondragos May 16, 2024
e8bd049
ci: Build frontend
robot-ci-heartex May 16, 2024
eace4c3
Trigger CI
hlomzik May 16, 2024
3e96f4a
ci: Build frontend
robot-ci-heartex May 17, 2024
0b5fbe6
Merge branch 'fb-leap-883/custom-scripts' into fb-leap-1060
Gondragos May 21, 2024
985d7a6
Fixed behavior in case of absence of event listeners
Gondragos May 21, 2024
9358e45
Merge branch 'fb-leap-883/custom-scripts' into fb-leap-1060
Gondragos May 21, 2024
3b09f44
Merge branch 'fb-leap-883/custom-scripts' into fb-leap-1060
Gondragos May 22, 2024
b36370c
Fix submitting without event handlers for beforeSaveAnnotation
Gondragos May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions web/libs/editor/src/stores/AppStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,15 @@ export default types

if (!entity.validate()) return;

entity.sendUserGenerate();
handleSubmittingFlag(async () => {
const allowedToSave = await getEnv(self).events.invoke("beforeSaveAnnotation", self, entity);
if (allowedToSave && allowedToSave.some((x) => x === false)) return;

entity.sendUserGenerate();
await getEnv(self).events.invoke(event, self, entity);
self.incrementQueuePosition();
entity.dropDraft();
});
entity.dropDraft();
}

function updateAnnotation(extraData) {
Expand All @@ -561,11 +564,14 @@ export default types
if (!entity.validate()) return;

handleSubmittingFlag(async () => {
const allowedToSave = await getEnv(self).events.invoke("beforeSaveAnnotation", self, entity);
if (allowedToSave && allowedToSave.some((x) => x === false)) return;

await getEnv(self).events.invoke("updateAnnotation", self, entity, extraData);
self.incrementQueuePosition();
entity.dropDraft();
!entity.sentUserGenerate && entity.sendUserGenerate();
});
entity.dropDraft();
!entity.sentUserGenerate && entity.sendUserGenerate();
}

function skipTask(extraData) {
Expand Down
Loading