Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1060: Add event to allow control annotations submitting #5891

Merged
merged 9 commits into from
May 23, 2024

Conversation

Gondragos
Copy link
Collaborator

This PR improves the way of saving annotations (submit and update) with allowing to prevent submitting in some cases such as validation.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

A missed useful event.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Annotation, Validation

@github-actions github-actions bot added the feat label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 3e96f4a
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66469e9d374f4d00082257a7

Copy link

netlify bot commented May 16, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 3e96f4a
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66469e9d374f4d00082257a5

@hlomzik hlomzik changed the base branch from develop to fb-leap-883/custom-scripts May 20, 2024 10:27
@hlomzik hlomzik merged commit 5f789d3 into fb-leap-883/custom-scripts May 23, 2024
@Gondragos Gondragos deleted the fb-leap-1060 branch October 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants