Fixed error in nb-NO resource file, added resource strings and added tests #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When counting "one", "ett" should be used instead of "et"
Added some tests for timespan in nb-NO locale. Fixed ett/et errors in the resource file
Added nb-NO localizations for the DateHumanize_*sFromNow that was missing from the nb-NO resource file. Added tests to acompany the settings.
| [InlineData(1, "i morgen")] | ||
| [InlineData(10, "10 dager fra nå")] | ||
| [InlineData(28, "28 dager fra nå")] | ||
| [InlineData(32, "en måned fra nå")] |
There was a problem hiding this comment.
Thanks for adding the tests in. I am also a fan of boundary tests like you've done with 32. Good work.
|
Please add your PR to the release notes file. Thanks. |
|
Removed redundant empty lines and updated release notes. |
|
Merged. Thanks for the great work. |
|
Thanks for your contribution. This is now released to nuget as v1.18.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When counting "one", "ett" should be used instead of "et"
Added tests for TimeSpan in nb-NO
Added resource strings from Resources.resx that were missing from Resources.nb-NO.resx. Mostly the future dates (DateHumanize_*FromNow) and DateHumanize_Now