Fixed error in nb-NO resource file, added resource strings and added tests #137
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| using System; | ||
| using Xunit; | ||
| using Xunit.Extensions; | ||
|
|
||
| namespace Humanizer.Tests.Localisation.nbNO | ||
| { | ||
| public class TimeSpanHumanizeTests : AmbientCulture | ||
|
There was a problem hiding this comment. Thanks for translating the TimeSpan resources and for the tests. TimeSpan was added much later to the lib and so it's missing translation for a lot of languages. |
||
| { | ||
| public TimeSpanHumanizeTests() : base("nb-NO") { } | ||
|
|
||
| [Theory] | ||
| [InlineData(7, "en uke")] | ||
| [InlineData(14, "2 uker")] | ||
| public void Weeks(int days, string expected) | ||
| { | ||
| Assert.Equal(expected, TimeSpan.FromDays(days).Humanize()); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1, "en dag")] | ||
| [InlineData(2, "2 dager")] | ||
| public void Days(int days, string expected) | ||
| { | ||
| Assert.Equal(expected, TimeSpan.FromDays(days).Humanize()); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1, "en time")] | ||
| [InlineData(2, "2 timer")] | ||
| public void Hours(int hours, string expected) | ||
| { | ||
| Assert.Equal(expected, TimeSpan.FromHours(hours).Humanize()); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1, "ett minutt")] | ||
| [InlineData(2, "2 minutter")] | ||
| public void Minutes(int minutes, string expected) | ||
| { | ||
| Assert.Equal(expected, TimeSpan.FromMinutes(minutes).Humanize()); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1, "ett sekund")] | ||
| [InlineData(2, "2 sekunder")] | ||
| public void Seconds(int seconds, string expected) | ||
| { | ||
| Assert.Equal(expected, TimeSpan.FromSeconds(seconds).Humanize()); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1, "ett millisekund")] | ||
| [InlineData(2, "2 millisekunder")] | ||
| public void Milliseconds(int milliseconds, string expected) | ||
| { | ||
| Assert.Equal(expected, TimeSpan.FromMilliseconds(milliseconds).Humanize()); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void NoTime() | ||
| { | ||
| Assert.Equal("ingen tid", TimeSpan.Zero.Humanize()); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests in. I am also a fan of boundary tests like you've done with 32. Good work.