Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-BR ToWords added #152

Closed
wants to merge 1 commit into from
Closed

pt-BR ToWords added #152

wants to merge 1 commit into from

Conversation

akamud
Copy link
Contributor

@akamud akamud commented Apr 10, 2014

This doesn't support gender differences for portuguese language, but handles all the others cases described here

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Thanks a lot for this. As mentioned in #15 this needs to be changed to use the new approach implemented in #149. I think this pulls the rug under your feet; so you might actually have to close this one, pull the latest and add your code based on the new approach.

Please also add your PR to the release notes file.

@akamud
Copy link
Contributor Author

akamud commented Apr 10, 2014

I'll be doing the new implementation in a different branch later today.

@akamud akamud closed this Apr 10, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Sorry for this. Thanks :)

@joaomatossilva
Copy link

I don't know the specific in pt-BR, but "pt-PT",
[InlineData(1000000000, "um bilhão")] is incorrect. it's "mil milhões".
http://pt.wikipedia.org/wiki/1000000000
http://pt.wikipedia.org/wiki/Escalas_curta_e_longa

@akamud
Copy link
Contributor Author

akamud commented Apr 10, 2014

I think we'll have to differentiate pt-PT from pt-BR. I was wondering if there were any differences.
In pt-BR is definitely "um bilhão".

@joaomatossilva
Copy link

http://www.languagesandnumbers.com/como-contar-em-portugues-europeu/pt/por-prt/
here you have the european portuguese rules.

btw, I was looking at the code and found out that if (ConverterFactories.TryGetValue(CultureInfo.CurrentUICulture.TwoLetterISOLanguageName, out converterFactory)) don't support pt-BR and pt-PT distinction.

I'll open a ticket for this, since it's another matter

@akamud
Copy link
Contributor Author

akamud commented Apr 10, 2014

Yes @kappy, I noticed that problem yesterday. But I thought there were no differences in counting, so I just implemented it as it would work for both. Clearly we'll have to treat them differently.

I'll be back home in 8 hours, we could discuss a way to treat that.

@akamud akamud deleted the feature/pt-BR-ToWords branch April 11, 2014 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants