Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource file for Vietnamese language. #269

Merged
merged 4 commits into from
May 21, 2014

Conversation

dotnetjunky
Copy link
Contributor

Add resource file for Vietnamese language.

@MehdiK
Copy link
Member

MehdiK commented May 20, 2014

Thanks for removing the unneeded file and fixing the build.

Please add the required unit tests and also add your PR to the release-notes file. More info on contribution guideline.

@dotnetjunky
Copy link
Contributor Author

done.

[InlineData(1299630020, 3, "2 tuần, 1 ngày, 1 giờ")]
[InlineData(1299630020, 4, "2 tuần, 1 ngày, 1 giờ, 30 giây")]
[InlineData(1299630020, 5, "2 tuần, 1 ngày, 1 giờ, 30 giây, 20 phần ngàn giây")]
public void TimeSpanWithPrecesion(int milliseconds, int precesion, string expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trips everyone up. You don't need to unit test these: if you're using testing every time unit in isolation, the combination is tested under English tests and will work. I will take them out.

@MehdiK MehdiK merged commit add7501 into Humanizr:master May 21, 2014
@MehdiK
Copy link
Member

MehdiK commented May 21, 2014

Merged. Thanks.

@MehdiK
Copy link
Member

MehdiK commented May 21, 2014

This is now released to NuGet as v1.26.1. Thanks for the addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants