Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Esperanto support to NumberToWords. Fixes #558 #569

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

aloisdg
Copy link
Contributor

@aloisdg aloisdg commented Jun 27, 2016

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings (Is there a global R# file?)
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change (needed?)
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one (Is there a list of language supported?)
  • Run either build.cmd or build.ps1 and ensure there are no test failures (failed but work in VS)

@aloisdg aloisdg mentioned this pull request Jun 27, 2016
5 tasks
@aloisdg
Copy link
Contributor Author

aloisdg commented Jun 27, 2016

How can I see the log of AppVeyor? I get — AppVeyor was unable to build non-mergeable pull request but I find it not very helpful.

@hangy
Copy link
Contributor

hangy commented Jun 28, 2016

No idea on how to get the log (might only be visible to an admin), but I just ran the build.cmd on your branch and it built just fine. Maybe just a transient error?

@aloisdg
Copy link
Contributor Author

aloisdg commented Jun 28, 2016

@hangy Thank you for your feedback

@hazzik
Copy link
Member

hazzik commented Jul 3, 2016

@onovotny can you take a look?

@clairernovotny
Copy link
Member

@hazzik @aloisdg I had to revert as I saw build errors: Build fails with eo-EO is an invalid culture identifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants