Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Humanizer 2.1 #567

Closed
5 tasks done
clairernovotny opened this issue Jun 26, 2016 · 13 comments
Closed
5 tasks done

Ship Humanizer 2.1 #567

clairernovotny opened this issue Jun 26, 2016 · 13 comments
Milestone

Comments

@clairernovotny
Copy link
Member

clairernovotny commented Jun 26, 2016

Issue to track shipping Humanizer 2.1.

In addition to the bug fixes since 2.0.1, this version will support netstandard. As such, it will also require a minimum NuGet version of 2.12 to install correctly.

@hazzik @aloisdg @mexx Please add items to this list that need to be complete before we ship.

@clairernovotny clairernovotny added this to the v2.1 milestone Jun 26, 2016
@aloisdg
Copy link
Contributor

aloisdg commented Jun 27, 2016

I am working to port Numbro to Humanizer. The related issue is #558. The PR should be ready as soon as #568 is fixed and I achieve to build 😄

Also:

  • I want to support Esperanto DateTime, but the code doesn't exist yet.
  • The support for the french "avant-hier/" and "après-demain" will be postpone.
  • There are old codes inside NumberToWords. I would like to move it C#6 (string interpolation, etc.). It could be postpone since it would be plain refactoring.

One item should be ready:

@hazzik
Copy link
Member

hazzik commented Jun 27, 2016

I would like to nominate following: (moved to the first message)

@aloisdg
Copy link
Contributor

aloisdg commented Jun 27, 2016

@onovotny Can you update the milestone in each issue/PR?

@aloisdg
Copy link
Contributor

aloisdg commented Jun 27, 2016

I would like to propose #518 by @i3arnon (PR: #519)

@hazzik
Copy link
Member

hazzik commented Jun 27, 2016

What if we just let the GitVersion decide the next version number? This will allow us to just ship without looking into the details and version holds.

@clairernovotny
Copy link
Member Author

clairernovotny commented Jul 3, 2016

@hazzik GitVersion is just a tool...it does whatever we want it to. In general, here's a good take on it:
https://docs.microsoft.com/en-us/dotnet/articles/core/versions/index#semantic-versioning

By that logic, it feels like a 2.1 for this release.

@hazzik
Copy link
Member

hazzik commented Jul 3, 2016

I know that this shall be a 2.1. But what I'm trying to say: we do +semver: hints on commits, and just release whatever version is calculated by GitVersion.

@hazzik
Copy link
Member

hazzik commented Jul 3, 2016

Hey-hey. I've merged #566. 🚢 the 2.1.

@clairernovotny
Copy link
Member Author

I generally tag the final version and that will automatically set it in GitVersion

@clairernovotny
Copy link
Member Author

clairernovotny commented Jul 3, 2016

Note that Humanizer is completely broken on dotnet CLI due to this: https://github.com/dotnet/cli/issues/3396. It won't install/restore succesfully. Only the english locale will work, Humanizer.Core.

Try it today with the MyGet/CI feed; you cannot restore it into an xproj. It works just fine in a csproj that uses netstandard.

@clairernovotny
Copy link
Member Author

I may have a workaround for this that I'm testing -- a Humanizer.xproj package that has all of the files and resources in the same package (like Humanizer 1.x did before the split). This should work but I'll verify. I'll nuke the package once the cli bug is fixed or things transition to msbuild in the fall.

@clairernovotny
Copy link
Member Author

Confirmed, the Humanizer.xproj works. Now just need docs and release notes and we're good to go.

@clairernovotny
Copy link
Member Author

2.1 has been pushed to NuGet. Should be visible soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants