Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match APU buffering to CPU ticks #29

Merged
merged 4 commits into from
May 2, 2020
Merged

Match APU buffering to CPU ticks #29

merged 4 commits into from
May 2, 2020

Conversation

Humpheh
Copy link
Owner

@Humpheh Humpheh commented May 2, 2020

Previously the APU ran completely without knowledge of how fast the CPU was running. This PR makes it so that the APU is buffered with the number of CPU ticks. This fixes issues with complex sounds such as in the opening of Pokemon Yellow.

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #29 into master will decrease coverage by 1.16%.
The diff coverage is 20.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   71.61%   70.45%   -1.17%     
==========================================
  Files          21       23       +2     
  Lines        2463     2505      +42     
==========================================
+ Hits         1764     1765       +1     
- Misses        665      706      +41     
  Partials       34       34              
Impacted Files Coverage Δ
pkg/gbio/iopixel/pixels.go 0.00% <0.00%> (ø)
pkg/apu/waves.go 5.88% <5.88%> (ø)
pkg/apu/channel.go 16.00% <16.00%> (ø)
pkg/apu/apu.go 31.28% <24.46%> (+0.30%) ⬆️
pkg/gb/gameboy.go 78.61% <33.33%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adead08...3d0368d. Read the comment docs.

@Humpheh Humpheh merged commit 1f1b37e into master May 2, 2020
@Humpheh Humpheh deleted the feature/sound-v3 branch May 2, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant