Saas/standard events feed #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniPlayer
approved these changes
Mar 15, 2021
| .name("geolocation.output.field.name") | ||
| .description("Label used to name the output record field for geolocation properties") | ||
| .required(false) | ||
| .sensitive(true) |
There was a problem hiding this comment.
Sensitive n'est pas utilisé actuellement je crois. Mais je ne pense pas que cette conf le soit XD. Ca serait plus pour des password ou autre.
| @@ -41,6 +41,18 @@ | |||
| * @return the json converted record | |||
| */ | |||
| static String convertToString(Record record) { | |||
| return convertToString(record, new String("location")); | |||
There was a problem hiding this comment.
I detect that this code is problematic. According to the Performance (PERFORMANCE), Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR).
Using the java.lang.String(String) constructor wastes memory because the object so constructed will be functionally indistinguishable from the String passed as a parameter. Just use the argument String directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.