Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic JSON encoder for case-classes #546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Generic JSON encoder for case-classes #546

wants to merge 2 commits into from

Conversation

otto-dev
Copy link

@otto-dev otto-dev commented Jul 2, 2019

Allows conversion of any Scala case class and tuples to/from JSON by importing mist.api.encoding.defaults._. Makes it unnecessary to create encoders for case classes.

Encoders for specific classes (case classes) will continue to take precedence over this generic encoder and extractor. Hence the ability to create specific encoders remains unaffected, and existing code will not break.

Derived from the examples in the documentation. I can't build and test mist locally beyond compilation because of time constrains.

I'm not sure if the import of shadedshapeless.Lazy is necessary.

Also, feel free to reject this pull request if there is a reason why this hasn't been implemented yet.

@otto-dev
Copy link
Author

otto-dev commented Jul 2, 2019

CI fails with a python syntax error thrown by a third party module pytest

@otto-dev otto-dev closed this Jul 2, 2019
@otto-dev otto-dev reopened this Jul 2, 2019
@dos65
Copy link
Contributor

dos65 commented Jul 2, 2019

I think it would be better to choose the most standard way in the ecosystem and put these instances into auto object. Like circe and pureconfig do this.

@otto-dev
Copy link
Author

otto-dev commented Jul 3, 2019

Sounds good to me. As long as you have a way to delegate the encoder creation to Scala. Planning to have a look when I find time, unless someone beats me to it. I first have to set up the build & test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants