Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 2 #3

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Feature 2 #3

merged 2 commits into from
Dec 10, 2021

Conversation

junghyunbak
Copy link
Contributor

[electron-in-puppeteer]

  • 즐겨찾기 과목이 많은 사람들은 모든 과목을 한번에 병렬 크롤링 할 경우 메모리 누수로 프로그램 뻗음.

▶ 여러개의 덩어리로 쪼개서 병렬 크롤링 하도록 수정

[react]

  • 페이지가 리랜더링 될 때 마다 ipc 수신부 (window.api.receive) 사라지지 않고 계속 늘어남.

▶ 모든 수신부 useEffect 함수 안에 작성

pr 이렇게 날리는거 맞나요? 😊

@HyeokjaeLee HyeokjaeLee merged commit 665017e into HyeokjaeLee:main Dec 10, 2021
@HyeokjaeLee HyeokjaeLee self-requested a review December 10, 2021 09:40
@junghyunbak junghyunbak deleted the feature_2 branch December 11, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeokjaeLee HyeokjaeLee Awaiting requested review from HyeokjaeLee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junghyunbak @HyeokjaeLee