Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockCollector should be able to detect repeated block (from same observer) and exclude it from block counting. #165

Closed
guoger opened this issue Apr 2, 2021 · 2 comments
Closed

BlockCollector should be able to detect repeated block (from same observer) and exclude it from block counting. #165

guoger opened this issue Apr 2, 2021 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed pinned Pin this issue to prevent from auto-closing

Comments

@guoger
Copy link
Member

guoger commented Apr 2, 2021

there might be chance (probably not now) that a block from same orderer shows up twice, and block collector could not distinguish it, and still uses it for counting.
@guoger guoger added bug Something isn't working help wanted Extra attention is needed pinned Pin this issue to prevent from auto-closing labels Apr 2, 2021
@yiwenlong
Copy link
Member

🙋

wuxuer added a commit to wuxuer/tape that referenced this issue Apr 8, 2021
@wuxuer
BlockCollector detects repeated block
002f105 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
@wuxuer wuxuer mentioned this issue Apr 8, 2021
Merged
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 12, 2021
@wuxuer
BlockCollector detects repeated block
1e5627d 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 12, 2021
@wuxuer
BlockCollector detects repeated block
79c84ed 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 12, 2021
@wuxuer
BlockCollector detects repeated block
13cb5d8 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 13, 2021
@wuxuer
BlockCollector detects repeated block
c699269 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 19, 2021
@wuxuer
BlockCollector detects repeated block
1f90f76 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 22, 2021
@wuxuer
BlockCollector detects repeated block
b6debb5 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 26, 2021
@wuxuer
BlockCollector detects repeated block
16abcb7 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
wuxuer added a commit to wuxuer/tape that referenced this issue Apr 27, 2021
@wuxuer
BlockCollector detects repeated block
818dce9 
BlockCollector detects repeated block from same observer and exclude it from block counting

Hyperledger-TWGC#165

Signed-off-by: wuxu <wuxu1103@163.com>
@wuxuer
Copy link
Contributor

wuxuer commented May 3, 2021

#172 has been merged, this issue can be closed!
@guoger @SamYuan1990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed pinned Pin this issue to prevent from auto-closing
Milestone
No milestone
Development

No branches or pull requests
4 participants
@guoger @SamYuan1990 @wuxuer @yiwenlong