BlockCollector detects repeated block #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoger
requested changes
Apr 8, 2021
wuxuer
force-pushed
the
issue165
branch
4 times, most recently
from
13cb5d8
to
c699269
Compare
SamYuan1990
reviewed
Apr 13, 2021
guoger
requested changes
Apr 19, 2021
SamYuan1990
reviewed
Apr 20, 2021
SamYuan1990
reviewed
Apr 20, 2021
SamYuan1990
requested changes
Apr 26, 2021
SamYuan1990
reviewed
Apr 26, 2021
BlockCollector detects repeated block from same observer and exclude it from block counting Hyperledger-TWGC#165 Signed-off-by: wuxu <wuxu1103@163.com>
SamYuan1990
approved these changes
Apr 28, 2021
SamYuan1990
requested review from
guoger and
SamYuan1990
and removed request for
guoger
guoger
reviewed
May 1, 2021
| // AddressedBlock describe the source of block | ||
| type AddressedBlock struct { | ||
| *peer.FilteredBlock | ||
| Address int // source peer's number |
There was a problem hiding this comment.
it would be nice to rename this field to PeerIdx in followup PR
guoger
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockCollector detects repeated block from same observer and exclude it from block counting
#165
Signed-off-by: wuxu wuxu1103@163.com