Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging supports with jaeger #223

Closed
SamYuan1990 opened this issue Nov 10, 2021 · 6 comments
Closed

Logging supports with jaeger #223

SamYuan1990 opened this issue Nov 10, 2021 · 6 comments
Assignees
Labels
pinned Pin this issue to prevent from auto-closing

Comments

@SamYuan1990
Copy link
Member

Is your proposal related to a problem?

N/A

(Write your answer here.)

Describe the solution you'd like

Ref to https://github.com/jaegertracing/jaeger/blob/master/examples/hotrod/pkg/log/factory.go#L44 make the logging supports for jaeger.

(Describe your proposed solution here.)

Describe alternatives you've considered

Considering running tape in container/k8s, by adding this kind of supports, we are able to trace logging by jaeger(as open tracing) fmt/file output as fluentd/console.

(Write your answer here.)

Additional context

If possible, please also help refactor with log system.

(Write your answer here.)

@SamYuan1990 SamYuan1990 added alpha pinned Pin this issue to prevent from auto-closing help wanted Extra attention is needed labels Nov 10, 2021
@SamYuan1990 SamYuan1990 self-assigned this Nov 13, 2021
@SamYuan1990
Copy link
Member Author

SamYuan1990 commented Nov 13, 2021

if env jaeger endpoints then send log to jaeger.
should tracing for each tx with a span.
for each business process should covered by a span.
for each IO waiting for SUT response should covered by a span.
error case span
IO to file for further analysis

logging
start transcation process
    // time for endorsement
    begin sign
    end sign
    before get endorsements     
        before endorsement // IO level
        end endorsement    // IO level
    end endorsements
    before integration proposal to envelop
    end integration proposal to envelop
    send envelop
    end transcation creation
    // time for consensus
    receive tx from blocking of orderer
    // time for peer commit
    starts waiting tx from peers
        receive tx from blocking event for peer
    end of from peers
end of transcation process

SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Nov 14, 2021
Signed-off-by: Sam Yuan <yy19902439@126.com>
SamYuan1990 added a commit that referenced this issue Nov 14, 2021
* impl for #223

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 removed the help wanted Extra attention is needed label Nov 14, 2021
@SamYuan1990
Copy link
Member Author

image

@SamYuan1990
Copy link
Member Author

image

@SamYuan1990
Copy link
Member Author

SamYuan1990 commented Dec 6, 2021

WechatIMG460

add a pic if we apply open tracing at peer and orderer side.

@davidkhala
Copy link
Member

davidkhala commented Mar 1, 2022

这个issue会不会替代现在的logger github.com/sirupsen/logrus

@SamYuan1990
Copy link
Member Author

@SamYuan1990 Sam,这个issue会同时替代现在的logger github.com/sirupsen/logrus么?

目前不会。

davidkhala pushed a commit that referenced this issue Mar 23, 2022
* impl for #223

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>
davidkhala pushed a commit that referenced this issue Mar 23, 2022
* 109 to alpha (#189)

* 1st impl for #109

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* Arch refactor alpha (#190)

* add crpto interface as repare for #127

Signed-off-by: Sam Yuan <yy19902439@126.com>

* adding Worker interface for #56 and decouple Assembler and Integrator

Signed-off-by: Sam Yuan <yy19902439@126.com>

* refactor for worker interface

Signed-off-by: Sam Yuan <yy19902439@126.com>

* package structure

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* package refactor

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* remove Envelope from elements

Signed-off-by: Sam Yuan <yy19902439@126.com>

* add memeory free

Signed-off-by: Sam Yuan <yy19902439@126.com>

* remove Proposal from Elements

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* move start time to ctx

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up for time setting (#191)

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for #173 supports for configurable signers in parallel (#194)

Signed-off-by: Sam Yuan <yy19902439@126.com>

* adding for commit phase only dummy impl (#195)

* adding for commit phase only dummy impl

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for endorsement only

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* update document and prepare for release (#196)

* update document and prepare for release

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up in readme (#197)

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for #200 (#207)

Signed-off-by: Sam Yuan <yy19902439@126.com>

* Impl173 (#208)

* adjust code

Signed-off-by: Sam Yuan <yy19902439@126.com>

* code refactor

Signed-off-by: Sam Yuan <yy19902439@126.com>

* code refactor

Signed-off-by: Sam Yuan <yy19902439@126.com>

* use const instead

Signed-off-by: Sam Yuan <yy19902439@126.com>

* adding parallel flag

Signed-off-by: Sam Yuan <yy19902439@126.com>

* try to check escapes in ci (#209)

* try to check escapes in ci

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* add benchmark test and adjust regex impl solution

Signed-off-by: Sam Yuan <yy19902439@126.com>

* attempt

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* 174 (#210)

* use kingpin global flag and adding test case with timeout command

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for #174

Signed-off-by: Sam Yuan <yy19902439@126.com>

* adding test case

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* add signal listening

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* adding patch for #174 (#211)

* adding patch for #174

Signed-off-by: Sam Yuan <yy19902439@126.com>

* bug fix

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for #213 (#214)

* impl for #213

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* add orderer observer into full workflow process (#216)

* add orderer observer into full workflow process

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for txid tracing at traffic generate (#218)

* impl for txid tracing at traffic generate

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* try to add tx tracing for observer (#219)

Signed-off-by: Sam Yuan <yy19902439@126.com>

* nit fix (#220)

Signed-off-by: Sam Yuan <yy19902439@126.com>

* Nitfix for date format (#221)

* use RFC3339Nano

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for #223 (#225)

* impl for #223

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up (#226)

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up (#227)

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up delete map to avoid OOM (#228)

Signed-off-by: Sam Yuan <yy19902439@126.com>

* update for git doc (#235)

Signed-off-by: Sam Yuan <yy19902439@126.com>

* impl for policy support (#237)

* add plan

Signed-off-by: Sam Yuan <yy19902439@126.com>

* update ginkgo and add test for policy impl

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* try to impl with policy support

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>

* fix up

Signed-off-by: Sam Yuan <yy19902439@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Pin this issue to prevent from auto-closing
Development

No branches or pull requests

2 participants