中英文文档合并以及Hyperledger文件重命名 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidkhala , I hope in this pr we can have some document upgrade as mentioned in #116 |
|
@SamYuan1990 but #116 has ambitious beyond tape as probe is also included. |
I see, or could you please help with #131 ? To be honest... I hope we can have a pr with large scope upgrade for document. |
|
@davidkhala commit需要sign-off |
davidkhala
force-pushed
the
davidkhala-patch-1
branch
2 times, most recently
from
c9dcc1e
to
6bae863
Compare
guoger
requested changes
Feb 7, 2021
Comment on lines
-124
to
-147
| ## Help us improve | ||
|
|
||
| If you wish for new features or encounter any bug, please feel free to open [issue](https://github.com/guoger/tape/issues), and we always welcome [pull request](https://github.com/guoger/tape/pulls). | ||
| ## [How to Contribute](CONTRIBUTING.md) | ||
|
|
||
| If you are reporting an issue, please generously turn on debug log with `export TAPE_LOGLEVEL=debug` and paste log in the issue | ||
| ## [Maintainers](MAINTAINERS.md) | ||
|
|
||
| ## Development | ||
| <details> | ||
| <summary>Click to expand</summary> | ||
|
|
||
| ### Tape workflow | ||
| ## LICENSE | ||
| Hyperledger Project source code files are made available under the Apache License, Version 2.0 (Apache-2.0), located in the [LICENSE](LICENSE) file. | ||
|
|
||
| Tape consists of several workers that run in goroutines, so that the pipeline is highly concurrent and scalable. Workers are connected via buffered channels, so they can pass products around. | ||
|
|
||
|  | ||
| </details> | ||
|
|
||
| ## Maintainers | ||
|
|
||
| | Name | mail | github-ID | ||
| | ------ | ------------------------ | ----------- | | ||
| | Jay Gou | guojiannan1101@gmail.com | guoger | | ||
| | Sam Yuan | yy19902439@126.com | SamYuan1990 | | ||
| | Stone Cheng | chengyang418@163.com | stone-ch | |
There was a problem hiding this comment.
not sure why we need to delete this section? IMO this makes readme more complete
There was a problem hiding this comment.
I planned to move this section to MAINTAINERS.md.
How about we set the title ##Maintainers here as a link to MAINTAINERS.md ?
davidkhala
force-pushed
the
davidkhala-patch-1
branch
from
42d9ebc
to
158c6db
Compare
davidkhala
commented
Feb 10, 2021
| @@ -0,0 +1,7 @@ | |||
| # Maintainers 维护者信息 | |||
|
|
|||
davidkhala
force-pushed
the
davidkhala-patch-1
branch
from
158c6db
to
9410b9b
Compare
davidkhala
force-pushed
the
davidkhala-patch-1
branch
2 times, most recently
from
a28f81a
to
ea62ad7
Compare
stone-ch
previously approved these changes
Mar 16, 2021
davidkhala
force-pushed
the
davidkhala-patch-1
branch
from
ea62ad7
to
8a7d7af
Compare
davidkhala
force-pushed
the
davidkhala-patch-1
branch
from
8a7d7af
to
d9248a3
Compare
stone-ch
previously approved these changes
Mar 16, 2021
格式更新 大型改动 Signed-off-by: David Liu <david.yx.liu@oracle.com>
davidkhala
force-pushed
the
davidkhala-patch-1
branch
from
d9248a3
to
d6edd4a
Compare
|
@stone-ch 刚才git reset的时候选错了方式，把代码搞乱了，现在应该好了 |
stone-ch
requested review from
guoger and
stone-ch
and removed request for
guoger and
SamYuan1990
stone-ch
approved these changes
Mar 16, 2021
guoger
approved these changes
Mar 27, 2021
|
close #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
格式更新
大型改动