-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl for #109 #187
impl for #109 #187
Conversation
Signed-off-by: Sam Yuan <yy19902439@126.com>
will check and update later. |
I think using dynamic template will be a better solution than hard-written functions under the proposal. But this pr serves as a good work-around for dynamic args right now. thanks for this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
func stringWithCharset(length int, charset string) string { | ||
b := make([]byte, length) | ||
for i := range b { | ||
b[i] = charset[seededRand.Intn(len(charset))] | ||
} | ||
return string(b) | ||
} | ||
|
||
func randomString(length int) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is only required by one func, how about merging them into one func?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ref to https://github.com/bojand/ghz/blob/ff10171546e3048d8bb2864207367935f2c43d1e/runner/calldata.go
defined key words and regex.
add ci for test with latest sample.
resolve #109
Signed-off-by: Sam Yuan yy19902439@126.com