impl for #109 #187
Closed
impl for #109 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Yuan <yy19902439@126.com>
|
will check and update later. |
|
I think using dynamic template will be a better solution than hard-written functions under the proposal. But this pr serves as a good work-around for dynamic args right now. thanks for this pr |
davidkhala
reviewed
Aug 22, 2021
Comment on lines
+294
to
+302
| func stringWithCharset(length int, charset string) string { | ||
| b := make([]byte, length) | ||
| for i := range b { | ||
| b[i] = charset[seededRand.Intn(len(charset))] | ||
| } | ||
| return string(b) | ||
| } | ||
|
|
||
| func randomString(length int) string { |
There was a problem hiding this comment.
If it is only required by one func, how about merging them into one func?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref to https://github.com/bojand/ghz/blob/ff10171546e3048d8bb2864207367935f2c43d1e/runner/calldata.go
defined key words and regex.
add ci for test with latest sample.
resolve #109
Signed-off-by: Sam Yuan yy19902439@126.com