Improve handling of Basic Auth passwords (colons) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to respect RFC 2617, the app must accept any password matching the following requirements:
```
user-pass = userid ":" password
userid = *<TEXT excluding ":">
password = *TEXT
```
The former implementation did not respect this, and did not take in account the `:` character in the password field.
The new implementation assumes that the usernames ends when the colon is found (so it can't contain one), and uses the other part
of the token as the password.
|
Linked issue: #36 |
|
NB: Travis failed because it's not up to date, but that's not the point of this PR, so it won't be fixed. |
|
Thank you very much for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to respect RFC 2617, the server must accept any password matching the following requirements:
The former implementation did not respect this, and did not take in account the
:character in the password field.The new implementation assumes that the usernames ends when the colon is found (so it can't contain one), and uses the other part
of the token as the password.