-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7 - Grant access to edit a document to a user #172
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @raphaelweis, @petitfa1, @Barnabepetit.
- You will find below changes required in the content.
- In the conversation, don't forget to replace "[FILL WITH FULL NAMES]" with your full names.
- Please amend the title of your commit so that the title is
SCENARIO: Grant access to edit a document to a user (see #7).
, moreover add new lines before "Co-Authored-By" so that GitHub can link it to your accounts.
2339c97
to
c669678
Compare
Thank you for your contribution to the code @louisduhalberruer. @raphaelweis, @petitfa1, @Barnabepetit, @louisduhalberruer, don't forget my other comments about the discussion (copyright grant) and git history. |
Changes to this ticket have been published |
efb3491
to
70c67f6
Compare
c7c79b2
to
4b6757a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution @raphaelweis, @petitfa1, @Barnabepetit, @louisduhalberruer!
Now the content seems to be OK for integration. Please just follow the contributing procedure:
- In the first message of the "conversation", don't forget to replace "[FILL WITH FULL NAMES]" with all of your full names.
- Please restructure the history with exactly 3 commits:
SCENARIO: Grant access to edit a document to a user (see #7).
(with.feature
files),TEST: Grant access to edit a document to a user (see #7).
(with.rb
files),FEATURE: Grant access to edit a document to a user (closes #7).
(with.js
files).
Note: If the committer in not an author, use the right git options to tell it. Keep mentioning every co-author of the commit in the github syntax.
The person who will validate the history will validate "Réécrire l'historique d'une séquence de contributions pour tenir compte des remarques des relecteurs" 😎
If you need help with interactive rebasing and splitting a commit, just ask. |
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com> Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
SCENARIO: Grant access to edit a document to a user
We, Raphaël WEIS, Fabien PETIT, Barnabé PETIT, Louis DUHALBERRUER, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.