Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7 - Grant access to edit a document to a user #172

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Barnabepetit
Copy link
Contributor

@Barnabepetit Barnabepetit commented Apr 17, 2024

SCENARIO: Grant access to edit a document to a user

We, Raphaël WEIS, Fabien PETIT, Barnabé PETIT, Louis DUHALBERRUER, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

Copy link
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @raphaelweis, @petitfa1, @Barnabepetit.

  • You will find below changes required in the content.
  • In the conversation, don't forget to replace "[FILL WITH FULL NAMES]" with your full names.
  • Please amend the title of your commit so that the title is SCENARIO: Grant access to edit a document to a user (see #7)., moreover add new lines before "Co-Authored-By" so that GitHub can link it to your accounts.

features/grant_document_access.feature Outdated Show resolved Hide resolved
features/grant_document_access.feature Outdated Show resolved Hide resolved
features/grant_document_access.feature Outdated Show resolved Hide resolved
features/grant_document_access.feature Outdated Show resolved Hide resolved
features/grant_document_access.feature Outdated Show resolved Hide resolved
features/grant_document_access.feature Outdated Show resolved Hide resolved
features/grant_document_access.feature Outdated Show resolved Hide resolved
@benel benel linked an issue Apr 26, 2024 that may be closed by this pull request
@louisduhalberruer louisduhalberruer force-pushed the feature-7 branch 4 times, most recently from 2339c97 to c669678 Compare May 29, 2024 14:55
@benel
Copy link
Member

benel commented Jun 1, 2024

Thank you for your contribution to the code @louisduhalberruer.

@raphaelweis, @petitfa1, @Barnabepetit, @louisduhalberruer, don't forget my other comments about the discussion (copyright grant) and git history.

@Barnabepetit Barnabepetit marked this pull request as ready for review June 7, 2024 13:16
@Barnabepetit
Copy link
Contributor Author

Changes to this ticket have been published

Copy link
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution @raphaelweis, @petitfa1, @Barnabepetit, @louisduhalberruer!

Now the content seems to be OK for integration. Please just follow the contributing procedure:

  • In the first message of the "conversation", don't forget to replace "[FILL WITH FULL NAMES]" with all of your full names.
  • Please restructure the history with exactly 3 commits:
    1. SCENARIO: Grant access to edit a document to a user (see #7). (with .feature files),
    2. TEST: Grant access to edit a document to a user (see #7). (with .rb files),
    3. FEATURE: Grant access to edit a document to a user (closes #7). (with .js files).
      Note: If the committer in not an author, use the right git options to tell it. Keep mentioning every co-author of the commit in the github syntax.

The person who will validate the history will validate "Réécrire l'historique d'une séquence de contributions pour tenir compte des remarques des relecteurs" 😎

@benel
Copy link
Member

benel commented Jun 8, 2024

If you need help with interactive rebasing and splitting a commit, just ask.

@benel benel changed the title Create grant_document_access.feature 7 - Grant access to edit a document to a user Jun 8, 2024
Barnabepetit and others added 3 commits June 12, 2024 15:58
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grant access to edit a document to a user
2 participants