feat(mqtt): Ignore received retained message to work around common us…

…er errors
Hypfer · Jun 20, 2021 · 26d8a4c · 26d8a4c
1 parent 32a12cf
commit 26d8a4c
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/backend/lib/mqtt/MqttController.js b/backend/lib/mqtt/MqttController.js
@@ -285,11 +285,22 @@ class MqttController {
                 });
             });
 
-            this.client.on("message", (topic, message) => {
+            this.client.on("message", (topic, message, packet) => {
                 if (!Object.prototype.hasOwnProperty.call(this.subscriptions, topic)) {
                     return;
                 }
                 const msg = message.toString();
+
+                //@ts-ignore
+                if (packet?.retain === true) {
+                    Logger.warn("Received a retained MQTT message. This is almost certainly an error. Discarding.", {
+                        topic: topic,
+                        message: msg
+                    });
+
+                    return;
+                }
+
                 this.subscriptions[topic](msg).then();
             });