refactor!(timers): Updating timers should be a PUT instead of a POST

Hypfer · Jun 9, 2022 · 9c57f0c · 9c57f0c
1 parent 560a50e
commit 9c57f0c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/backend/lib/webserver/TimerRouter.js b/backend/lib/webserver/TimerRouter.js
@@ -79,7 +79,7 @@ class TimerRouter {
             }
         });
 
-        this.router.post("/:id", this.validator, (req, res) => {
+        this.router.put("/:id", this.validator, (req, res) => {
             const storedTimers = this.config.get("timers");
 
             if (storedTimers[req.params.id]) {

diff --git a/backend/lib/webserver/doc/TimerRouter.openapi.json b/backend/lib/webserver/doc/TimerRouter.openapi.json
@@ -136,7 +136,7 @@
         }
       }
     },
-    "post": {
+    "put": {
       "tags": [
         "Timers"
       ],

diff --git a/frontend/src/api/client.ts b/frontend/src/api/client.ts
@@ -555,7 +555,7 @@ export const sendTimerCreation = async (timerData: Timer): Promise<void> => {
 
 export const sendTimerUpdate = async (timerData: Timer): Promise<void> => {
     await valetudoAPI
-        .post(`/timers/${timerData.id}`, timerData)
+        .put(`/timers/${timerData.id}`, timerData)
         .then(({ status }) => {
             if (status !== 200) {
                 throw new Error("Could not update timer");