Add support for no-mopping zones on S5 Max and S6 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-mopping zones are like no-go zones, but they are only active when mopping. Very useful for drawing around rugs and carpets. They are available on the S5 Max and the S6, but not the S5. The screenshot above shows how the robot is forced to take an alternate route because of a no-mop zone in the way.
They can be added in the Configure forbidden zones view of Valetudo. They show up purple to match the stock Mi-Home app.
I have tested the functionality on my S6 and everything works correctly. I expect it will work fine on the S5 max as well, but I don't have one.
Known Issues:
The button to create a no-mop zone will still appear on the S5. So we will need some way to conditionally display buttons in the Configure forbidden zones page. This is sort of an architectural decision, so I would like to hear suggestions.
I wasn't able to find a suitable icon in the provided FontAwesome pack. So I just chose a placeholder for now. tint-slash could work nicely.