Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voluptuous.error.MultipleInvalid: extra keys not allowed @ data['availability_mode'] #858

Closed
makuser opened this issue Apr 26, 2021 · 2 comments · Fixed by #859
Closed
Labels
bug Something isn't working

Comments

@makuser
Copy link
Contributor

makuser commented Apr 26, 2021

Describe the bug

availability_mode: "latest",

availability_mode is a relatively new attribute, unfortunately since it is not expected by hass.
home-assistant/core@d60fc0d#diff-0d67e0c95bc8b8efc20c8d5491b8ed7a6634598a9fcdc954f96a1077a2c77e7aR81
Any version prior to 2021.4.6 will probably throw an exception and not work with it.

To Reproduce

  1. Install latest Home Assistant on latest packaged python on Raspbian (Home Assistant 2021.1.5), or hey actually any version before 2021.4.6, which was released JUST SEVEN DAYS AGO... https://www.home-assistant.io/blog/2021/04/07/release-20214/#release-202146---april-19
  2. Update Valetudo to 2021.04.0
  3. Do the workaround to rediscover mqtt devices as described on the release page
  4. No longer be able to use valetudo with hass...

Vacuum Model

Roborock S5 Max

Valetudo Version

2021.04.0

Expected behavior

Additional context

Since all it does is to set the "availability_mode" to 'latest', you can just scratch that, since it's the default anyway...

@makuser makuser added the bug Something isn't working label Apr 26, 2021
makuser added a commit to makuser/Valetudo that referenced this issue Apr 26, 2021
Hypfer pushed a commit that referenced this issue Apr 26, 2021
@Hypfer
Copy link
Owner

Hypfer commented Apr 26, 2021

Interestingly, I didn't experience any issues while testing against my local setup that is Home Assistant 2021.4.0

Either I've missed something or they've added a more tolerant error handling in a HA version newer than 2021.1.5 but older than 2021.4.6

@depau
Copy link
Contributor

depau commented Apr 26, 2021

Oh okay I see then. Disregard my comment in the PR then. I'd suggest to leave it commented in the code though, and explain why it is commented. So that someone who wants to change it to a different value gets the opportunity to think twice and make an informed choice.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants